third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js - Issue 1707043002: [DevTools] Support CommandLineAPI in snippets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

Issue 1707043002: [DevTools] Support CommandLineAPI in snippets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | third_party/WebKit/Source/devtools/protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

index ed412cc53871a09b31e6ea584317555436491395..9c350e3aca3f2594b69ed46014655b43c0ee86ff 100644

--- a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

@@ -260,7 +260,7 @@ WebInspector.ScriptSnippetModel.prototype = {

_runScript: function(scriptId, executionContext, sourceURL)

{

var target = executionContext.target();

- target.runtimeModel.runScript(scriptId, executionContext.id, "console", false, runCallback.bind(this, target));

+ target.runtimeModel.runScript(scriptId, executionContext.id, "console", false, true, runCallback.bind(this, target));

/**

* @param {!WebInspector.Target} target