[WIP][SVG 3/4] Allow invalid data: URLs to be served synchronously by Resource::load()

third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
     Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 313 matching lines @@
         memoryCache()->remove(oldResource);
     }
 
     WebString mimetype;
     WebString charset;
     RefPtr<SharedBuffer> data;
     if (substituteData.isValid()) {
         mimetype = substituteData.mimeType();
         charset = substituteData.textEncoding();
         data = substituteData.content();
+        ASSERT(data);
     } else {
         WrappedResourceRequest wrappedRequest(request.resourceRequest());
         WebData webData;
         if (!Platform::current()->parseDataURLIfCanBeHandledLocally(wrappedRequest, mimetype, charset, webData))
             return nullptr;
         data = PassRefPtr<SharedBuffer>(webData);
-        if (!data)
-            return nullptr;
     }
+
+    RefPtrWillBeRawPtr<Resource> resource = factory.create(request.resourceRequest(), request.charset());
+    resource->setNeedsSynchronousCacheHit(substituteData.forceSynchronousLoad());
+    resource->setOptions(request.options());
+
+    if (!data) {
+        // We don't add |resource| to MemoryCache because it has an error,
+        // but make ResourceFetcher::requestResource() to return this
+        // Resource to make all data font URLs to be resolved synchronously.
+        // https://crbug.com/382170
+        resource->error(Resource::LoadError);

[Nate Chapin, 2016/03/01 23:11:34]

ASSERT(url.protocolIsData()) here, just to be clear that SubstituteData loads
shouldn't error like this?

+        return resource.release();
+    }
+
     ResourceResponse response(url, mimetype, data->size(), charset, String());
     response.setHTTPStatusCode(200);
     response.setHTTPStatusText("OK");
 
-    RefPtrWillBeRawPtr<Resource> resource = factory.create(request.resourceRequest(), request.charset());
-    resource->setNeedsSynchronousCacheHit(substituteData.forceSynchronousLoad());
-    resource->setOptions(request.options());
     // FIXME: We should provide a body stream here.
     resource->responseReceived(response, nullptr);
     resource->setDataBufferingPolicy(BufferData);
     if (data->size())
         resource->setResourceBuffer(data);
     resource->setIdentifier(createUniqueIdentifier());
     resource->setCacheIdentifier(cacheIdentifier);
     resource->finish();
     memoryCache()->add(resource.get());
     return resource.release();
@@ skipping 858 matching lines @@
     visitor->trace(m_loaders);
     visitor->trace(m_nonBlockingLoaders);
 #if ENABLE(OILPAN)
     visitor->trace(m_documentResources);
     visitor->trace(m_preloads);
     visitor->trace(m_resourceTimingInfoMap);
 #endif
 }
 
 } // namespace blink