Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1706973002: Use dart.global instead of window in debugger.dart (Closed)

Created:
4 years, 10 months ago by ochafik
Modified:
4 years, 10 months ago
Reviewers:
vsm, devoncarew, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/runtime/dart/_debugger.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/debugger.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (4 generated)
ochafik
Hey guys, tiny fix for node
4 years, 10 months ago (2016-02-18 16:01:13 UTC) #2
vsm
lgtm Not sure this should run out of the browser in general though. But I ...
4 years, 10 months ago (2016-02-18 16:16:33 UTC) #5
ochafik
Committed patchset #2 (id:20001) manually as 73dd398a5b2cf551ad4792094bb8e98eaedf159f (presubmit successful).
4 years, 10 months ago (2016-02-18 16:38:06 UTC) #7
Jacob
4 years, 10 months ago (2016-02-22 17:17:56 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1706973002/diff/20001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/1706973002/diff/20001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:539: JS('', 'dart.global.devtoolsFormatters
= #', formatters);
This need to be exposed on the window object not the dart.global object.
The correct fix would be to check that there is a window object and only apply
if there is one.

Powered by Google App Engine
This is Rietveld 408576698