Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1706963005: [Swarming] Bundle jsfunfuzz. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Bundle jsfunfuzz. This downloads a patched version of jsfunfuzz from google storage (google internal bucket) as a hook on demand. Similar to the gcmole approach from https://codereview.chromium.org/1703533002/ BUG=chromium:535160 LOG=n Committed: https://crrev.com/7a9ebb5846f3870efba798671e5d057ef3f11850 Cr-Commit-Position: refs/heads/master@{#34106}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -23 lines) Patch
M .gitignore View 1 chunk +2 lines, -2 lines 1 comment Download
M DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/fuzz-harness.sh View 3 chunks +23 lines, -16 lines 1 comment Download
A + tools/jsfunfuzz/download_jsfunfuzz.py View 1 chunk +5 lines, -5 lines 0 comments Download
A tools/jsfunfuzz/jsfunfuzz.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1706963005/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/1706963005/diff/1/.gitignore#newcode71 .gitignore:71: /tools/jsfunfuzz/jsfunfuzz Is git friendly to checkouts where the ...
4 years, 10 months ago (2016-02-18 09:03:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706963005/1
4 years, 10 months ago (2016-02-18 09:04:32 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 09:35:57 UTC) #8
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-18 09:39:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706963005/1
4 years, 10 months ago (2016-02-18 09:46:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:47:27 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a9ebb5846f3870efba798671e5d057ef3f11850 Cr-Commit-Position: refs/heads/master@{#34106}
4 years, 10 months ago (2016-02-18 09:47:45 UTC) #15
kjellander_chromium
4 years, 10 months ago (2016-02-18 15:22:19 UTC) #16
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698