Fix "^" in --match flag for nanobench SKPs

Fix "^" in --match flag for nanobench SKPs

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706923002

Committed: https://skia.googlesource.com/skia/+/91e457d17f8c6c06de33eb2bb430a90ba472eda5

[Chris Dalton, 2016-02-17 18:17:08]

Description was changed from

==========
Fix "^" in --match flag for nanobench SKPs

BUG=skia:
==========

to

==========
Fix "^" in --match flag for nanobench SKPs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-02-17 18:21:36]

cdalton@nvidia.com changed reviewers:
+ mtklein@google.com

[Chris Dalton, 2016-02-17 18:21:36]

https://codereview.chromium.org/1706923002/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1706923002/diff/1/bench/nanobench.cpp#newcode612
bench/nanobench.cpp:612: if (SkCommandLineFlags::ShouldSkip(FLAGS_match,
SkOSPath::Basename(path).c_str())) {
I can think of a more elaborate fix if we want to avoid calling Basename twice,
but I didn't feel like it was really necessary.

[mtklein, 2016-02-17 18:23:59]

lgtm

Where'd the "^" come from?

[Chris Dalton, 2016-02-17 18:24:57]

On 2016/02/17 18:23:59, mtklein wrote:
> lgtm
> 
> Where'd the "^" come from?

For example, "--match ^mypicture.skp$" -- the '^' character wasn't working.

[mtklein, 2016-02-17 18:26:50]

On 2016/02/17 18:24:57, Chris Dalton wrote:
> On 2016/02/17 18:23:59, mtklein wrote:
> > lgtm
> > 
> > Where'd the "^" come from?
> 
> For example, "--match ^mypicture.skp$" -- the '^' character wasn't working.

Ah!  Thought you meant there was a "^" in the path to the .skp.

[Chris Dalton, 2016-02-17 18:27:41]

On 2016/02/17 18:26:50, mtklein wrote:
> On 2016/02/17 18:24:57, Chris Dalton wrote:
> > On 2016/02/17 18:23:59, mtklein wrote:
> > > lgtm
> > > 
> > > Where'd the "^" come from?
> > 
> > For example, "--match ^mypicture.skp$" -- the '^' character wasn't working.
> 
> Ah!  Thought you meant there was a "^" in the path to the .skp.

Oh, ok. Is this ok then or should I modify the commit message?

[mtklein, 2016-02-17 18:28:17]

On 2016/02/17 18:27:41, Chris Dalton wrote:
> On 2016/02/17 18:26:50, mtklein wrote:
> > On 2016/02/17 18:24:57, Chris Dalton wrote:
> > > On 2016/02/17 18:23:59, mtklein wrote:
> > > > lgtm
> > > > 
> > > > Where'd the "^" come from?
> > > 
> > > For example, "--match ^mypicture.skp$" -- the '^' character wasn't
working.
> > 
> > Ah!  Thought you meant there was a "^" in the path to the .skp.
> 
> Oh, ok. Is this ok then or should I modify the commit message?

Nope, I was just confused.  lgtm

[Chris Dalton, 2016-02-17 18:29:38]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-02-17 18:29:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706923002/1

[commit-bot: I haz the power, 2016-02-17 19:10:18]

Description was changed from

==========
Fix "^" in --match flag for nanobench SKPs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix "^" in --match flag for nanobench SKPs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/91e457d17f8c6c06de33eb2bb430a90ba472eda5
==========

[commit-bot: I haz the power, 2016-02-17 19:10:19]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/91e457d17f8c6c06de33eb2bb430a90ba472eda5