Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 17069004: Fix Iteration on gc stress builder. (Closed)

Created:
7 years, 6 months ago by Hannes Payer (out of office)
Modified:
7 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix Iteration on gc stress builder. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15178

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/test-heap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-14 13:18:47 UTC) #1
Michael Starzinger
https://codereview.chromium.org/17069004/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/17069004/diff/1/test/cctest/test-heap.cc#newcode880 test/cctest/test-heap.cc:880: HeapIterator iterator(heap); The correct fix is actually to add ...
7 years, 6 months ago (2013-06-14 13:30:15 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/17069004/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/17069004/diff/1/test/cctest/test-heap.cc#newcode880 test/cctest/test-heap.cc:880: HeapIterator iterator(heap); On 2013/06/14 13:30:15, Michael Starzinger wrote: > ...
7 years, 6 months ago (2013-06-14 13:44:38 UTC) #3
Michael Starzinger
LGTM.
7 years, 6 months ago (2013-06-14 13:47:33 UTC) #4
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-17 06:52:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r15178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698