Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1706893003: Revert of Bot update cleanup (Closed)

Created:
4 years, 10 months ago by Ryan Tseng
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Bot update cleanup (patchset #5 id:80001 of https://codereview.chromium.org/1686273002/ ) Reason for revert: Separating change into smaller changes. Original issue's description: > Bot update cleanup > > * Remove activation check > * Remove messages > * Remove deps2git > * Remove build_internal pointer by: > ** Moving chrome svn url into bot_update.py (This isn't secret anyways.) > ** Move patch.exe into depot_tools (No reason this should've been internal...) > ** Default everything to active, so no need for checks anyways. > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298809 TBR=martiniss@chromium.org,eseidel@chromium.org,estaab@chromium.org,iannucci@chromium.org,hinoka@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+699 lines, -383 lines) Patch
M recipe_modules/bot_update/api.py View 7 chunks +25 lines, -6 lines 0 comments Download
M recipe_modules/bot_update/example.py View 1 chunk +53 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 2 chunks +9 lines, -16 lines 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 2 chunks +8 lines, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 2 chunks +9 lines, -16 lines 0 comments Download
A recipe_modules/bot_update/example.expected/off.json View 1 chunk +44 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 2 chunks +9 lines, -16 lines 0 comments Download
A recipe_modules/bot_update/example.expected/svn_mode.json View 1 chunk +60 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/resources/bot_update.py View 26 chunks +372 lines, -29 lines 0 comments Download
D recipe_modules/bot_update/resources/patch.exe View Binary file 0 comments Download
M recipe_modules/bot_update/test_api.py View 1 chunk +50 lines, -38 lines 0 comments Download
D tests/bot_update_coverage_test.py View 1 chunk +0 lines, -261 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Ryan Tseng
Created Revert of Bot update cleanup
4 years, 10 months ago (2016-02-17 19:39:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706893003/1
4 years, 10 months ago (2016-02-17 19:39:32 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 19:42:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298826

Powered by Google App Engine
This is Rietveld 408576698