Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1706863002: Add layout tests for Cache.matchAll() w/o parameters (Closed)

Created:
4 years, 10 months ago by nolan.robin.cao
Modified:
4 years, 10 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout tests for Cache.matchAll() w/o parameters Add a layout test case for Cache.matchAll() without parameters. BUG=578708 Committed: https://crrev.com/5b5a48e55c659ecb8119544e64a4d37b5fe7a2ab Cr-Commit-Position: refs/heads/master@{#376082}

Patch Set 1 #

Patch Set 2 : Update layout test results #

Messages

Total messages: 14 (7 generated)
nolan.robin.cao
Please take a look, thanks.
4 years, 10 months ago (2016-02-17 16:08:59 UTC) #3
nhiroki
lgtm
4 years, 10 months ago (2016-02-18 01:13:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706863002/20001
4 years, 10 months ago (2016-02-18 01:16:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 03:28:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706863002/20001
4 years, 10 months ago (2016-02-18 03:29:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 03:35:25 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 03:36:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b5a48e55c659ecb8119544e64a4d37b5fe7a2ab
Cr-Commit-Position: refs/heads/master@{#376082}

Powered by Google App Engine
This is Rietveld 408576698