Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1706823003: Use displayName in Error.stack rendering if present. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use displayName in Error.stack rendering if present. BUG=v8:4761 LOG=y Committed: https://crrev.com/953874e974037e7e96ef282a7078760ccc905878 Cr-Commit-Position: refs/heads/master@{#34105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/js/messages.js View 4 chunks +13 lines, -8 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/stack-traces-display-name.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-18 08:50:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706823003/1
4 years, 10 months ago (2016-02-18 08:50:47 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-18 08:52:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 09:17:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706823003/1
4 years, 10 months ago (2016-02-18 09:41:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:42:51 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/953874e974037e7e96ef282a7078760ccc905878 Cr-Commit-Position: refs/heads/master@{#34105}
4 years, 10 months ago (2016-02-18 09:43:12 UTC) #12
Toon Verwaest
4 years, 10 months ago (2016-02-18 19:18:34 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1713663002/ by verwaest@chromium.org.

The reason for reverting is: See Domenic's comment on the V8 bug..

Powered by Google App Engine
This is Rietveld 408576698