Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Issue 17068016: Move the npruntime_util.h/.cc files from webkit\glue to content\child. (Closed)

Created:
7 years, 6 months ago by ananta
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Move the npruntime_util.h/.cc files from webkit\glue to content\child. This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249 which is splitting chrome.dll into a browser and renderer component due to build issues on Windows. BUG=237249 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207922

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -96 lines) Patch
A + content/child/npruntime_util.h View 1 chunk +10 lines, -11 lines 0 comments Download
A + content/child/npruntime_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/plugin_param_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/plugin_param_traits.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
D webkit/glue/npruntime_util.h View 1 chunk +0 lines, -24 lines 0 comments Download
D webkit/glue/npruntime_util.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ananta
7 years, 6 months ago (2013-06-21 20:02:25 UTC) #1
jamesr
lgtm
7 years, 6 months ago (2013-06-21 20:40:44 UTC) #2
ananta
TBR'ing darin for content\child owners review
7 years, 6 months ago (2013-06-21 21:13:19 UTC) #3
ananta
Committed patchset #3 manually as r207922 (presubmit successful).
7 years, 6 months ago (2013-06-21 21:18:53 UTC) #4
darin (slow to review)
7 years, 6 months ago (2013-06-21 22:06:58 UTC) #5
Message was sent while issue was closed.
LGTM2

Powered by Google App Engine
This is Rietveld 408576698