Remove IsInitialized checks from inlined API functions.

Remove IsInitialized checks from inlined API functions.

R=marja@chromium.org, svenpanne@chromium.org
TEST=cctest/test-api

Committed: http://code.google.com/p/v8/source/detail?r=15277

[marja, 2013-06-21 14:02:21]

lgtm from a non-owner :)

[Sven Panne, 2013-06-24 08:23:48]

LGTM with a nit.

https://codereview.chromium.org/17068006/diff/3001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/17068006/diff/3001/include/v8.h#newcode5938
include/v8.h:5938: #ifdef V8_ENABLE_CHECKS
Moving the #ifdef to the CheckInitialized declaration (would become an inline
function with an empty body in release mode then) is probably a bit nicer,
reducing macro usage is almost always a good thing.

[Michael Starzinger, 2013-06-24 08:54:55]

Addressed comments. Landing.

https://codereview.chromium.org/17068006/diff/3001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/17068006/diff/3001/include/v8.h#newcode5938
include/v8.h:5938: #ifdef V8_ENABLE_CHECKS
On 2013/06/24 08:23:48, Sven Panne wrote:
> Moving the #ifdef to the CheckInitialized declaration (would become an inline
> function with an empty body in release mode then) is probably a bit nicer,
> reducing macro usage is almost always a good thing.

Done. As discussed offline, this will require the embedder to be compiled with
the same value of V8_ENABLE_CHECKS as V8 itself, otherwise linking will fail. In
case that ever bites us, then this can be fixed by always using an inline
wrapper and renaming the implementation to "CheckInitializedImpl" so that this
symbol is always available.

[Michael Starzinger, 2013-06-24 08:58:09]

Committed patchset #3 manually as r15277 (presubmit successful).