Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1706793002: Don't add to uncommonAttributeRules for non-sharable cases. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't add to uncommonAttributeRules for non-sharable cases. Like for siblingRules in [1], we don't need to add rules to uncommonAttributeRules if the attribute selectors are left of ::content, ::slotted, :host, or :host-context as two elements only may share style if they match the same elements left of the two former, and anything left of the two latter may never match. [1] https://codereview.chromium.org/1695393002/ R=kochi@chromium.org Committed: https://crrev.com/71d114fe5969d9b1def4d91657409537ff88b886 Cr-Commit-Position: refs/heads/master@{#376106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp View 2 chunks +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706793002/1
4 years, 10 months ago (2016-02-17 13:27:21 UTC) #2
rune
ptal
4 years, 10 months ago (2016-02-17 13:27:32 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 16:13:00 UTC) #5
kochi
lgtm
4 years, 10 months ago (2016-02-18 02:36:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706793002/1
4 years, 10 months ago (2016-02-18 06:12:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 06:20:07 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 06:21:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71d114fe5969d9b1def4d91657409537ff88b886
Cr-Commit-Position: refs/heads/master@{#376106}

Powered by Google App Engine
This is Rietveld 408576698