Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1706773002: Fix memory leak (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrPathRenderingDrawContext.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrPathRenderingDrawContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-17 13:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706773002/1
4 years, 10 months ago (2016-02-17 13:17:58 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-17 13:18:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/6514)
4 years, 10 months ago (2016-02-17 13:18:58 UTC) #9
tomhudson
Drive-by LGTM. TBR= didn't add Brian to the Reviewers email; doing so manually.
4 years, 10 months ago (2016-02-17 13:21:50 UTC) #11
robertphillips
lgtm
4 years, 10 months ago (2016-02-17 13:21:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706773002/1
4 years, 10 months ago (2016-02-17 13:22:09 UTC) #15
djsollen
api lgtm, but indents (really?)...
4 years, 10 months ago (2016-02-17 13:24:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706773002/1
4 years, 10 months ago (2016-02-17 13:38:26 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 13:40:04 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8db867820bd9cd31b8aea14632a05739f5d44965

Powered by Google App Engine
This is Rietveld 408576698