src/ia32/assembler-ia32.h - Issue 1706763002: [turbofan] Emit memory operands for cmp and test on ia32 and x64 when it makes sense.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32.h

Issue 1706763002: [turbofan] Emit memory operands for cmp and test on ia32 and x64 when it makes sense. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add support for opcode 0x39 in the ia32 disassembler. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/assembler-ia32.h

diff --git a/src/ia32/assembler-ia32.h b/src/ia32/assembler-ia32.h

index 29a90f92a04e63589a2d3bdda9f6ba1600ab6386..f517c9878e011c1ceedfb289a941c15574f4e0c0 100644

--- a/src/ia32/assembler-ia32.h

+++ b/src/ia32/assembler-ia32.h

@@ -678,6 +678,7 @@ class Assembler : public AssemblerBase {

void cmp(Register reg0, Register reg1) { cmp(reg0, Operand(reg1)); }

void cmp(Register reg, const Operand& op);

void cmp(Register reg, const Immediate& imm) { cmp(Operand(reg), imm); }

+ void cmp(const Operand& op, Register reg);

void cmp(const Operand& op, const Immediate& imm);

void cmp(const Operand& op, Handle<Object> handle);

« src/compiler/instruction-selector.cc ('K') | « src/compiler/x64/instruction-selector-x64.cc ('k') | src/ia32/assembler-ia32.cc » ('j') | no next file with comments »