Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: src/ia32/assembler-ia32.cc

Issue 1706763002: [turbofan] Emit memory operands for cmp and test on ia32 and x64 when it makes sense. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/assembler-ia32.h ('k') | src/ia32/disasm-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 emit_arith(7, Operand(reg), Immediate(handle)); 796 emit_arith(7, Operand(reg), Immediate(handle));
797 } 797 }
798 798
799 799
800 void Assembler::cmp(Register reg, const Operand& op) { 800 void Assembler::cmp(Register reg, const Operand& op) {
801 EnsureSpace ensure_space(this); 801 EnsureSpace ensure_space(this);
802 EMIT(0x3B); 802 EMIT(0x3B);
803 emit_operand(reg, op); 803 emit_operand(reg, op);
804 } 804 }
805 805
806 void Assembler::cmp(const Operand& op, Register reg) {
807 EnsureSpace ensure_space(this);
808 EMIT(0x39);
809 emit_operand(reg, op);
810 }
806 811
807 void Assembler::cmp(const Operand& op, const Immediate& imm) { 812 void Assembler::cmp(const Operand& op, const Immediate& imm) {
808 EnsureSpace ensure_space(this); 813 EnsureSpace ensure_space(this);
809 emit_arith(7, op, imm); 814 emit_arith(7, op, imm);
810 } 815 }
811 816
812 817
813 void Assembler::cmp(const Operand& op, Handle<Object> handle) { 818 void Assembler::cmp(const Operand& op, Handle<Object> handle) {
814 EnsureSpace ensure_space(this); 819 EnsureSpace ensure_space(this);
815 emit_arith(7, op, Immediate(handle)); 820 emit_arith(7, op, Immediate(handle));
(...skipping 2133 matching lines...) Expand 10 before | Expand all | Expand 10 after
2949 fflush(coverage_log); 2954 fflush(coverage_log);
2950 } 2955 }
2951 } 2956 }
2952 2957
2953 #endif 2958 #endif
2954 2959
2955 } // namespace internal 2960 } // namespace internal
2956 } // namespace v8 2961 } // namespace v8
2957 2962
2958 #endif // V8_TARGET_ARCH_IA32 2963 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32.h ('k') | src/ia32/disasm-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698