[turbofan] Emit memory operands for cmp and test on ia32 and x64 when it makes sense.

src/compiler/ia32/code-generator-ia32.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 
 #include "src/ast/scopes.h"
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/gap-resolver.h"
 #include "src/compiler/node-matchers.h"
@@ skipping 510 matching lines @@
       }
       break;
     case kIA32And:
       if (HasImmediateInput(instr, 1)) {
         __ and_(i.InputOperand(0), i.InputImmediate(1));
       } else {
         __ and_(i.InputRegister(0), i.InputOperand(1));
       }
       break;
     case kIA32Cmp:
-      if (HasImmediateInput(instr, 1)) {
-        __ cmp(i.InputOperand(0), i.InputImmediate(1));
+      if (AddressingModeField::decode(instr->opcode()) != kMode_None) {
+        size_t index = 0;
+        Operand memop = i.MemoryOperand(&index);

[Benedikt Meurer, 2016/02/18 05:02:53]

Nit: Please use "operand" instead of "memop" to be consistent with the rest of
the file.

[epertoso, 2016/02/18 10:58:29]

Done.

+        if (HasImmediateInput(instr, index)) {
+          __ cmp(memop, i.InputImmediate(index));
+        } else {
+          __ cmp(memop, i.InputRegister(index));
+        }
       } else {
-        __ cmp(i.InputRegister(0), i.InputOperand(1));
+        if (HasImmediateInput(instr, 1)) {
+          __ cmp(i.InputOperand(0), i.InputImmediate(1));
+        } else {
+          __ cmp(i.InputRegister(0), i.InputOperand(1));
+        }
       }
       break;
     case kIA32Test:
-      if (HasImmediateInput(instr, 1)) {
-        __ test(i.InputOperand(0), i.InputImmediate(1));
+      if (AddressingModeField::decode(instr->opcode()) != kMode_None) {
+        size_t index = 0;
+        Operand memop = i.MemoryOperand(&index);

[Benedikt Meurer, 2016/02/18 05:02:53]

Nit: Please use "operand" instead of "memop" to be consistent with the rest of
the file.

[epertoso, 2016/02/18 10:58:29]

Done.

+        if (HasImmediateInput(instr, index)) {
+          __ test(memop, i.InputImmediate(index));
+        } else {
+          __ test(i.InputRegister(index), memop);
+        }
       } else {
-        __ test(i.InputRegister(0), i.InputOperand(1));
+        if (HasImmediateInput(instr, 1)) {
+          __ test(i.InputOperand(0), i.InputImmediate(1));
+        } else {
+          __ test(i.InputRegister(0), i.InputOperand(1));
+        }
       }
       break;
     case kIA32Imul:
       if (HasImmediateInput(instr, 1)) {
         __ imul(i.OutputRegister(), i.InputOperand(0), i.InputInt32(1));
       } else {
         __ imul(i.OutputRegister(), i.InputOperand(1));
       }
       break;
     case kIA32ImulHigh:
@@ skipping 1182 matching lines @@
     int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
     __ Nop(padding_size);
   }
 }
 
 #undef __
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8