Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1706743002: [intrinsics] Remove the %_IsSimdValue intrinsic. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Remove the %_IsSimdValue intrinsic. There's no need to have inline platform code for this intrinsic, which is only used when generating a descriptive string for an error, the runtime call is just fine here. R=jarin@chromium.org Committed: https://crrev.com/0200dd5621aef2193018433d1947db42cca75cd8 Cr-Commit-Position: refs/heads/master@{#34080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -178 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-17 11:44:30 UTC) #1
Benedikt Meurer
Hey Jaro, Another obvious useless optimization gone. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-17 11:45:09 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-17 11:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706743002/1
4 years, 10 months ago (2016-02-17 12:53:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 10 months ago (2016-02-17 13:44:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706743002/1
4 years, 10 months ago (2016-02-17 13:49:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 13:54:00 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 13:55:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0200dd5621aef2193018433d1947db42cca75cd8
Cr-Commit-Position: refs/heads/master@{#34080}

Powered by Google App Engine
This is Rietveld 408576698