Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170673005: [Android] More eager gesture recognition hardening (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] More eager gesture recognition hardening Handle several corner cases of touch event handling, particularly if an exception occurs between |onTouchEventHandlingBegin| and |onTouchEventHandlingEnd| in ContentViewGestureHandler. BUG=344674, 341495 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252282

Patch Set 1 #

Patch Set 2 : Add type DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -30 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_packet.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_packet.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 chunk +28 lines, -27 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
jdduke (slow)
wangxianzhu@: PTAL. Some fuzz tests uncovered some potential issues here when we're given a garbage ...
6 years, 10 months ago (2014-02-19 18:50:56 UTC) #1
Xianzhu
lgtm
6 years, 10 months ago (2014-02-19 20:02:34 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 20:09:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-19 20:26:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 20:53:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 20:53:26 UTC) #6
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 21:17:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-19 21:19:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 21:24:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 21:24:18 UTC) #10
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 23:06:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-19 23:16:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-20 01:06:02 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 01:31:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-20 01:31:21 UTC) #15
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-20 01:43:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-20 02:06:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-20 05:17:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-20 09:17:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170673005/70001
6 years, 10 months ago (2014-02-20 12:33:56 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 17:07:45 UTC) #21
Message was sent while issue was closed. 
Change committed as 252282

Powered by Google App Engine
This is Rietveld 408576698