Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1706703002: X87: [runtime] Introduce FastNewStrictArgumentsStub to optimize strict arguments. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Introduce FastNewStrictArgumentsStub to optimize strict arguments. port 09d845354742a90fc0596262eb5cbaac169e5ed9(r33925) original commit message: The FastNewStrictArgumentsStub is very similar to the recently added FastNewRestParameterStub, it's actually almost a copy of it, except that it doesn't have the fast case we have for the empty rest parameter. This patch improves strict arguments in TurboFan and fullcodegen by up to 10x compared to the previous version. Also introduce proper JSSloppyArgumentsObject and JSStrictArgumentsObject for the in-object properties instead of having them as constants in the Heap class. Drive-by-fix: Use this stub and the FastNewRestParameterStub in the interpreter to avoid the runtime call overhead for strict arguments and rest parameter creation. BUG= Committed: https://crrev.com/82289a989d603e76a86f56258f117a35e07c82ef Cr-Commit-Position: refs/heads/master@{#34055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -126 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +24 lines, -19 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +117 lines, -104 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-17 07:00:23 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-17 07:10:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706703002/1
4 years, 10 months ago (2016-02-17 07:11:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 07:22:46 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 07:23:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82289a989d603e76a86f56258f117a35e07c82ef
Cr-Commit-Position: refs/heads/master@{#34055}

Powered by Google App Engine
This is Rietveld 408576698