Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1706673002: X87: [es6] Further fixing of tail Calls. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Further fixing of tail Calls. port e519e6fadfaf7242231f4dcb45910f60304e26fc(r33886) original commit message: 1) Update profiling counters in Full codegen. 2) Call Runtime::kTraceTailCall when tracing is on test/mjsunit/es6/tail-call-simple.js is disabled for now, because Turbofan does not fully support TCO yet. BUG= Committed: https://crrev.com/3ada8da360037d84f6676b9c09171fbe2181373c Cr-Commit-Position: refs/heads/master@{#34054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +33 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-17 04:49:25 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-17 06:31:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706673002/1
4 years, 10 months ago (2016-02-17 06:34:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 06:55:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 06:57:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ada8da360037d84f6676b9c09171fbe2181373c
Cr-Commit-Position: refs/heads/master@{#34054}

Powered by Google App Engine
This is Rietveld 408576698