components/web_cache/public/interfaces/web_cache_service.mojom - Issue 1706603004: Replace web_cache_messages.h with Mojo service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_cache/public/interfaces/web_cache_service.mojom

Issue 1706603004: Replace web_cache_messages.h with Mojo service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Ken's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module web_cache.mojom;

	6

	7 interface WebCacheService {

	8 // Set cache capacity values.

	9 // Each call is independent, overlapping calls are possible.
	Anand Mistry (off Chromium) 2016/02/18 12:33:57 I don't understand this comment. These are all one I don't understand this comment. These are all one-way messages, and an interface provides strict ordering of calls. I can't see how overlap is relevant here. leonhsl(Using Gerrit) 2016/02/19 08:37:41 Yeah I think you're right, this interface has no s Show quoted text On 2016/02/18 12:33:57, Anand Mistry wrote: > I don't understand this comment. These are all one-way messages, and an > interface provides strict ordering of calls. I can't see how overlap is relevant > here. Yeah I think you're right, this interface has no such worry. Removed this comment.
	10 SetCacheCapacities(uint64 min_dead_capacity,

	11 uint64 max_dead_capacity,

	12 uint64 capacity);

	13 // Clear cache.

	14 // Each call is independent, overlapping calls are possible.

	15 ClearCache(bool on_navigation);

	16 };

OLD	NEW