components/web_cache/common/BUILD.gn - Issue 1706603004: Replace web_cache_messages.h with Mojo service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_cache/common/BUILD.gn

Issue 1706603004: Replace web_cache_messages.h with Mojo service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("common") {	5 import("//mojo/public/tools/bindings/mojom.gni")

	6

	7 mojom("common") {
	Ken Rockot(use gerrit already) 2016/02/18 03:45:06 It's a bit unconventional to have a target named " It's a bit unconventional to have a target named "common" be a mojom target. I think we should reinforce the convention that mojom lives in foo/public/interfaces, so can you move this BUILD.gn, OWNERS, and the mojom file to //components/web_cache/public/interfaces? leonhsl(Using Gerrit) 2016/02/18 08:56:22 Understood and Done. Show quoted text On 2016/02/18 03:45:06, Ken Rockot wrote: > It's a bit unconventional to have a target named "common" be a mojom target. I > think we should reinforce the convention that mojom lives in > foo/public/interfaces, so can you move this BUILD.gn, OWNERS, and the mojom file > to //components/web_cache/public/interfaces? Understood and Done.
6 sources = [	8 sources = [

7 "web_cache_message_generator.cc",	9 "web_cache_service.mojom",

8 "web_cache_message_generator.h",

9 "web_cache_messages.h",

10 ]

11

12 deps = [

13 "//ipc",

14 ]	10 ]

15 }	11 }

OLD	NEW