third_party/WebKit/Source/core/css/CSSGradientValue.cpp - Issue 1706573002: Move background related longhands into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSGradientValue.cpp

Issue 1706573002: Move background related longhands into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix logic error Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/gradients/unprefixed-gradient-parsing-expected.txt ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSGradientValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSGradientValue.cpp b/third_party/WebKit/Source/core/css/CSSGradientValue.cpp

index 0a76377836fe4ace2f8c270281870a49f2a9ceda..2f8c60f4906d1cbf03271f629133c6d1bd9de88b 100644

--- a/third_party/WebKit/Source/core/css/CSSGradientValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSGradientValue.cpp

@@ -524,6 +524,8 @@ static float positionFromValue(CSSValue* value, const CSSToLengthConversionData&

case CSSValueRight:

ASSERT(isHorizontal);

return size.width();

+ case CSSValueCenter:

+ return origin + sign * .5f * edgeDistance;

default:

break;

}