Chrome Task Scheduler Task Traits

base/task_scheduler/task_traits.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/task_traits.h"
+
+namespace base {
+
+TaskTraits::TaskTraits()

[gab, 2016/02/16 22:15:43]

Add a comment like: 

// Do not rely on defaults hard-coded below beyond the guarantees described in
the header, anything else is subject to change. Tasks should explicitly requests
defaults they depend on beyond the specifications of the API.

[robliao, 2016/02/16 22:58:31]

Added a variant of the blurb.

+    : with_file_io_(false),
+      priority_(TaskPriority::BACKGROUND),
+      shutdown_behavior_(TaskShutdownBehavior::BLOCK_SHUTDOWN) {}
+
+TaskTraits::~TaskTraits() = default;

[gab, 2016/02/16 22:15:43]

TaskTraits is only made of POD types so the destructor can be inlined (i.e.
remove it from here and header and use default one)

[robliao, 2016/02/16 22:58:31]

The current guidance is this:
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-i...

I've no strong opinion either way, but we've already got a implementation file,
so it doesn't change much either way.

+
+TaskTraits& TaskTraits::WithFileIO() {
+  with_file_io_ = true;
+  return *this;
+}
+
+TaskTraits& TaskTraits::WithPriority(TaskPriority priority) {
+  priority_ = priority;
+  return *this;
+}
+
+TaskTraits& TaskTraits::WithShutdownBehavior(TaskShutdownBehavior behavior) {
+  shutdown_behavior_ = behavior;
+  return *this;
+}
+
+}  // namespace base