Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1706443002: skiaserve: Change alpha setting from GET to POST. (Closed)

Created:
4 years, 10 months ago by jcgregorio
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skiaserve: Change alpha setting from GET to POST. GET shouldn't be used for things that change the state of the server. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706443002 Committed: https://skia.googlesource.com/skia/+/3341d428d3e49803e4f31f439a193e9e2c199daa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/skiaserve/skiaserve.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
jcgregorio
4 years, 10 months ago (2016-02-16 17:47:00 UTC) #4
ethannicholas
lgtm
4 years, 10 months ago (2016-02-16 17:48:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706443002/1
4 years, 10 months ago (2016-02-16 17:48:37 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 18:31:10 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3341d428d3e49803e4f31f439a193e9e2c199daa

Powered by Google App Engine
This is Rietveld 408576698