Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1706413002: Indexed DB: Rename "int version" to "version" (Closed)

Created:
4 years, 10 months ago by jsbell
Modified:
4 years, 10 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, cmumford, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, jsbell+idb_chromium.org, blink-reviews-api_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Indexed DB: Rename "int version" to "version" Now that the obsolete "string version" has been removed in a previous CL, tidy up the name. BUG=542419 Committed: https://crrev.com/e9c26d71a89eb3f518fb46024d24d4c2f7055c78 Cr-Commit-Position: refs/heads/master@{#377388}

Patch Set 1 #

Patch Set 2 : Update inspector test, fix presubmit issues #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -204 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 7 chunks +27 lines, -32 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 16 chunks +26 lines, -28 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database_unittest.cc View 5 chunks +11 lines, -27 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 3 chunks +6 lines, -15 lines 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_metadata.h View 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_metadata.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-structure.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt View 1 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/Inspector-1.1.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 1 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBMetadata.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBMetadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/indexeddb/WebIDBMetadata.h View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
jsbell
cmumford@ - can you sanity check? If it looks good I'll rope in OWNERS.
4 years, 10 months ago (2016-02-18 20:00:46 UTC) #1
jsbell
cmumford@ - can you take a look? If it looks good I'll rope in OWNERS ...
4 years, 10 months ago (2016-02-18 20:01:22 UTC) #3
cmumford
lgtm
4 years, 10 months ago (2016-02-18 22:18:01 UTC) #4
jsbell
pfeldman@ - can you review devtools changes? tsepez@ - can you review messaging changes?
4 years, 10 months ago (2016-02-18 23:08:44 UTC) #6
Tom Sepez
RS LGTM on rename.
4 years, 10 months ago (2016-02-19 00:12:26 UTC) #7
jsbell
pfeldman@ - ping?
4 years, 10 months ago (2016-02-22 23:09:26 UTC) #8
pfeldman
devtools lgtm
4 years, 10 months ago (2016-02-23 23:23:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706413002/20001
4 years, 10 months ago (2016-02-23 23:53:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/26086) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-24 00:10:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706413002/40001
4 years, 10 months ago (2016-02-24 18:44:39 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 21:23:45 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 21:24:47 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e9c26d71a89eb3f518fb46024d24d4c2f7055c78
Cr-Commit-Position: refs/heads/master@{#377388}

Powered by Google App Engine
This is Rietveld 408576698