Fix javac sometimes not create all outputs with enable_incremental_javac

Fix javac sometimes not create all outputs with enable_incremental_javac

The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.

Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do

BUG=none

Committed: https://crrev.com/891533bc3d53d336c95895de6d780647f46d608f
Cr-Commit-Position: refs/heads/master@{#376984}

[agrieve, 2016-02-19 01:19:00]

Description was changed from

==========
Fix javac sometimes not create all outputs with enable_incremental_javac

The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.

Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do

BUG=none
==========

to

==========
Fix javac sometimes not create all outputs with enable_incremental_javac

The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.

Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do

BUG=none
==========

[agrieve, 2016-02-19 01:19:00]

agrieve@chromium.org changed reviewers:
+ nyquist@chromium.org

[agrieve, 2016-02-19 01:19:14]

On 2016/02/19 01:19:00, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:nyquist@chromium.org

📦

[agrieve, 2016-02-19 01:20:56]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 01:22:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706363003/20001

[commit-bot: I haz the power, 2016-02-19 01:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 01:44:53]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nyquist, 2016-02-19 20:57:12]

lgtm

https://codereview.chromium.org/1706363003/diff/20001/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1706363003/diff/20001/build/android/gyp/javac...
build/android/gyp/javac.py:233: if os.path.exists(pdb_path) and not
os.path.getsize(pdb_path):
Nit: Should you add if options.incremental here? Otherwise, I don't think
|pdb_path| would necessarily be set at this point.

[agrieve, 2016-02-23 02:55:21]

https://codereview.chromium.org/1706363003/diff/20001/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1706363003/diff/20001/build/android/gyp/javac...
build/android/gyp/javac.py:233: if os.path.exists(pdb_path) and not
os.path.getsize(pdb_path):
On 2016/02/19 20:57:12, nyquist wrote:
> Nit: Should you add if options.incremental here? Otherwise, I don't think
> |pdb_path| would necessarily be set at this point.

The bots agree with you! Done.

[agrieve, 2016-02-23 02:55:29]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 02:56:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706363003/40001

[commit-bot: I haz the power, 2016-02-23 04:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 04:12:08]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-02-23 15:11:04]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-02-23 15:11:04]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1706363003/#ps40001
(title: "missing if")

[commit-bot: I haz the power, 2016-02-23 15:11:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706363003/40001

[commit-bot: I haz the power, 2016-02-23 15:17:39]

Description was changed from

==========
Fix javac sometimes not create all outputs with enable_incremental_javac

The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.

Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do

BUG=none
==========

to

==========
Fix javac sometimes not create all outputs with enable_incremental_javac

The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.

Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do

BUG=none
==========

[commit-bot: I haz the power, 2016-02-23 15:17:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-23 15:18:31]

Description was changed from

==========
Fix javac sometimes not create all outputs with enable_incremental_javac

The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.

Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do

BUG=none
==========

to

==========
Fix javac sometimes not create all outputs with enable_incremental_javac

The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.

Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do

BUG=none

Committed: https://crrev.com/891533bc3d53d336c95895de6d780647f46d608f
Cr-Commit-Position: refs/heads/master@{#376984}
==========

[commit-bot: I haz the power, 2016-02-23 15:18:32]

Patchset 3 (id:??) landed as
https://crrev.com/891533bc3d53d336c95895de6d780647f46d608f
Cr-Commit-Position: refs/heads/master@{#376984}