content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 1706353002: Added the selected text marker range to the dictionary for the selection change notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 1706353002: Added the selected text marker range to the dictionary for the selection change notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now works the first time you start the browser. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_manager.h » ('j') | content/browser/accessibility/browser_accessibility_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index cc4735217e614309d0476ec4eaa602dc52d35a40..a03b9278e68f8176caae232213a2a2afe2a178ee 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -191,6 +191,7 @@ NSString* GetTextForTextMarkerRange(AXTextMarkerRangeRef marker_range) {

DCHECK(start_object && end_object);

DCHECK_GE(start_offset, 0);

DCHECK_GE(end_offset, 0);

+ LOG(ERROR) << "GetTextRange at " << start_offset << ' ' << end_offset << ' ' << [[start_object->ToBrowserAccessibilityCocoa() role] UTF8String];

dmazzoni 2016/02/18 21:16:42 nit: remove this before landing

return base::SysUTF16ToNSString(BrowserAccessibilityManager::GetTextForRange(

*start_object, start_offset, *end_object, end_offset));