content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 1706353002: Added the selected text marker range to the dictionary for the selection change notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 1706353002: Added the selected text marker range to the dictionary for the selection change notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed standard text fields. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index 84415e1785bf7386e20290f7178d57c1dd5d4550..daa45b0501bc69ce662578c95baffa826a9278e1 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -1775,11 +1775,10 @@ bool InitializeAccessibilityTreeSearch(

return nil;

DCHECK(object);

- if (object->IsTextOnlyObject() &&

+ if ((object->IsSimpleTextControl() || object->IsTextOnlyObject()) &&

offset < static_cast<int>(object->GetText().length())) {

++offset;

} else {

- offset = 0;

while (object &&

!(object->IsTextOnlyObject() && object->GetText().length() == 0)) {

object = BrowserAccessibilityManager::NextTextOnlyObject(object);

@@ -1800,7 +1799,8 @@ bool InitializeAccessibilityTreeSearch(

return nil;

DCHECK(object);

- if (object->IsTextOnlyObject() && offset > 0) {

+ if ((object->IsSimpleTextControl() || object->IsTextOnlyObject()) &&

+ offset > 0) {

--offset;

} else {

while (object &&

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_manager_mac.mm » ('j') | no next file with comments »