Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: Source/bindings/v8/custom/V8PopStateEventCustom.cpp

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Large set of fixes from adamk and haraken. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8PopStateEventCustom.cpp
diff --git a/Source/bindings/v8/custom/V8PopStateEventCustom.cpp b/Source/bindings/v8/custom/V8PopStateEventCustom.cpp
index 43ac29ac220fb1fe3a44680d28495d7987644381..6843a2879dbb43f866187f7f35770066ec9ec51a 100644
--- a/Source/bindings/v8/custom/V8PopStateEventCustom.cpp
+++ b/Source/bindings/v8/custom/V8PopStateEventCustom.cpp
@@ -56,8 +56,9 @@ void V8PopStateEvent::stateAttrGetterCustom(v8::Local<v8::String> name, const v8
}
PopStateEvent* event = V8PopStateEvent::toNative(info.Holder());
- if (!event->state().hasNoValue()) {
- v8SetReturnValue(info, cacheState(info.Holder(), event->state().v8Value()));
+ v8::Handle<v8::Value> cachedState = info.Holder()->GetHiddenValue(V8HiddenPropertyName::state());
+ if (!cachedState.IsEmpty()) {
+ v8SetReturnValue(info, cachedState);
return;
}

Powered by Google App Engine
This is Rietveld 408576698