Source/bindings/tests/results/V8TestEventConstructor.cpp - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestEventConstructor.cpp

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Minor rebase nits. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestEventConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestEventConstructor.cpp b/Source/bindings/tests/results/V8TestEventConstructor.cpp

index 820d1459471265a72d2a8aa73264871e58d12948..1794dc33acdea267957dff63bba1f7b80b3b5a69 100644

--- a/Source/bindings/tests/results/V8TestEventConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestEventConstructor.cpp

@@ -105,7 +105,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& args)

v8::Handle<v8::Object> wrapper = args.Holder();

V8DOMWrapper::associateObjectWithWrapper(event.release(), &V8TestEventConstructor::info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);

- args.GetReturnValue().Set(wrapper);

+ v8SetReturnValue(args, wrapper);

}

} // namespace TestEventConstructorV8Internal

« no previous file with comments | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | Source/bindings/v8/Dictionary.h » ('j') | no next file with comments »