Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: Source/core/dom/PopStateEvent.cpp

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added GC test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/dom/MessageEvent.cpp ('K') | « Source/core/dom/PopStateEvent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/PopStateEvent.cpp
diff --git a/Source/core/dom/PopStateEvent.cpp b/Source/core/dom/PopStateEvent.cpp
index 072d28ba177377fa4f55318709e6094a4e0b8980..ea574de2ea9d8612687a17b0a4bdf10692aec3c2 100644
--- a/Source/core/dom/PopStateEvent.cpp
+++ b/Source/core/dom/PopStateEvent.cpp
@@ -47,9 +47,9 @@ PopStateEvent::PopStateEvent()
PopStateEvent::PopStateEvent(const AtomicString& type, const PopStateEventInit& initializer)
: Event(type, initializer)
- , m_state(initializer.state)
, m_serializedState(0)
, m_history(0)
+ , m_stateIsSet(initializer.stateIsSet)
{
ScriptWrappable::init(this);
}
@@ -58,6 +58,7 @@ PopStateEvent::PopStateEvent(PassRefPtr<SerializedScriptValue> serializedState,
: Event(eventNames().popstateEvent, false, true)
, m_serializedState(serializedState)
, m_history(history)
+ , m_stateIsSet(false)
{
ScriptWrappable::init(this);
}
« Source/core/dom/MessageEvent.cpp ('K') | « Source/core/dom/PopStateEvent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698