Source/bindings/v8/Dictionary.h - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/Dictionary.h

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed some test failures, fixed some nits, and generalized the new events test. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/event-isolated-world.html ('K') | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | Source/bindings/v8/custom/V8CustomEventCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/Dictionary.h

diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h

index 3d1519c00482cbcf1a1600846ae6be49c6638e96..0cc3e4e56345808ca1f29ce4c9a964364970b5e6 100644

--- a/Source/bindings/v8/Dictionary.h

+++ b/Source/bindings/v8/Dictionary.h

@@ -93,6 +93,7 @@ public:

bool get(const String&, RefPtr<CSSFontFaceRule>&) const;

bool get(const String&, RefPtr<DOMError>&) const;

bool get(const String&, RefPtr<VoidCallback>&) const;

+ bool get(const String&, v8::Local<v8::Value>&) const;

bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;

bool getOwnPropertyNames(Vector<String>&) const;