Remove leak of objects between isolated worlds on custom events.

Source/bindings/v8/custom/V8CustomEventCustom.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8DOMWrapper.h"
 #include "bindings/v8/V8HiddenPropertyName.h"
 #include "core/dom/ContextFeatures.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/page/Frame.h"
 #include "RuntimeEnabledFeatures.h"
 
 namespace WebCore {
 
+static v8::Handle<v8::Value> cacheState(v8::Handle<v8::Object> customEvent, v8::Handle<v8::Value> detail)
+{
+    customEvent->SetHiddenValue(V8HiddenPropertyName::detail(), detail);
+    return detail;
+}
+
+
 void V8CustomEvent::detailAttrGetterCustom(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

[haraken, 2013/06/27 04:50:27]

Why does this method need to be custom? I guess this can be auto-generated. You
don't need to do it in this CL, but I hope you improve the code generator in a
follow-up CL :)

[jww, 2013/06/27 17:44:42]

This function has always been custom (in fact, it was the only custom function
in CustomEvent before this CL). We could auto generate it, but CustomEvent would
be the only consumer of it; PopStateEvent and MessageEvent have pretty different
getters. To me, a single consumer is almost the definition of a custom function,
and it seems odd to me to auto-generate for this one function.

That having been said, there is a fair amount of overlap between PopStateEvent's
getter and this one, so it's *possible* they could be combined in a reasonable
way, but that does seem like a separate CL to me.

[haraken, 2013/06/28 00:08:01]

I'd guess it's worth auto-generating this method, since the generated code is a
general one for a DOM attribute getter of type 'any'. I don't know if there are
other users of the generated code at this point, basically it would be worth
auto-generating this kind of general code. Either way you can try it in a
separate CL.

 {
-    CustomEvent* imp = V8CustomEvent::toNative(info.Holder());
-    RefPtr<SerializedScriptValue> serialized = imp->serializedScriptValue();
-    if (serialized) {
-        v8::Handle<v8::Value> value = info.Holder()->GetHiddenValue(V8HiddenPropertyName::detail());
-        if (value.IsEmpty()) {
-            value = serialized->deserialize();
-            info.Holder()->SetHiddenValue(V8HiddenPropertyName::detail(), value);
-        }
-        v8SetReturnValue(info, value);
+    CustomEvent* event = V8CustomEvent::toNative(info.Holder());
+    ASSERT(!event->serializedScriptValue().get());
+
+    v8::Handle<v8::Value> result = info.Holder()->GetHiddenValue(V8HiddenPropertyName::detail());
+
+    if (!result.IsEmpty()) {
+        v8SetReturnValue(info, result);
         return;
     }
-    v8SetReturnValue(info, imp->detail().v8Value());
+
+    RefPtr<SerializedScriptValue> serialized = event->serializedScriptValue();
+    if (serialized) {
+        result = serialized->deserialize();
+        v8SetReturnValue(info, cacheState(info.Holder(), result));
+        return;
+    }
+
+    v8SetReturnValue(info, cacheState(info.Holder(), v8Null(info.GetIsolate())));
+}
+
+void V8CustomEvent::initCustomEventMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+{
+    CustomEvent* event = V8CustomEvent::toNative(args.Holder());
+    String typeArg = toWebCoreString(args[0]);

[haraken, 2013/06/27 04:50:27]

You should use V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID().

[jww, 2013/06/27 17:44:42]

Done.

+    bool canBubbleArg = args[1]->BooleanValue();

[haraken, 2013/06/27 04:50:27]

You should use V8TRYCATCH_VOID().

[jww, 2013/06/27 17:44:42]

Done.

+    bool cancelableArg = args[2]->BooleanValue();

[haraken, 2013/06/27 04:50:27]

Ditto.

[jww, 2013/06/27 17:44:42]

Done.

+    v8::Handle<v8::Value> detailsArg = args[3];
+
+    args.Holder()->SetHiddenValue(V8HiddenPropertyName::detail(), detailsArg);
+    event->initEvent(typeArg, canBubbleArg, cancelableArg);
 }
 
 } // namespace WebCore