Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: Source/bindings/v8/Dictionary.h

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reverted to version that expects GetHiddenValue to not return an empty Handle for undefined Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 bool get(const String&, RefPtr<SpeechRecognitionResultList>&) const; 86 bool get(const String&, RefPtr<SpeechRecognitionResultList>&) const;
87 bool get(const String&, RefPtr<MediaStream>&) const; 87 bool get(const String&, RefPtr<MediaStream>&) const;
88 bool get(const String&, RefPtr<EventTarget>&) const; 88 bool get(const String&, RefPtr<EventTarget>&) const;
89 bool get(const String&, HashSet<AtomicString>&) const; 89 bool get(const String&, HashSet<AtomicString>&) const;
90 bool get(const String&, Dictionary&) const; 90 bool get(const String&, Dictionary&) const;
91 bool get(const String&, Vector<String>&) const; 91 bool get(const String&, Vector<String>&) const;
92 bool get(const String&, ArrayValue&) const; 92 bool get(const String&, ArrayValue&) const;
93 bool get(const String&, RefPtr<CSSFontFaceRule>&) const; 93 bool get(const String&, RefPtr<CSSFontFaceRule>&) const;
94 bool get(const String&, RefPtr<DOMError>&) const; 94 bool get(const String&, RefPtr<DOMError>&) const;
95 bool get(const String&, RefPtr<VoidCallback>&) const; 95 bool get(const String&, RefPtr<VoidCallback>&) const;
96 bool get(const String&, v8::Local<v8::Value>&) const;
96 97
97 bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const; 98 bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;
98 bool getOwnPropertyNames(Vector<String>&) const; 99 bool getOwnPropertyNames(Vector<String>&) const;
99 100
100 bool getWithUndefinedOrNullCheck(const String&, String&) const; 101 bool getWithUndefinedOrNullCheck(const String&, String&) const;
101 102
102 PassRefPtr<EventListener> getEventListener(const String&, Notification*) con st { return 0; } 103 PassRefPtr<EventListener> getEventListener(const String&, Notification*) con st { return 0; }
103 104
104 private: 105 private:
105 bool getKey(const String& key, v8::Local<v8::Value>&) const; 106 bool getKey(const String& key, v8::Local<v8::Value>&) const;
106 107
107 // This object can only be used safely when stack allocated because of v8::L ocal. 108 // This object can only be used safely when stack allocated because of v8::L ocal.
108 static void* operator new(size_t); 109 static void* operator new(size_t);
109 static void* operator new[](size_t); 110 static void* operator new[](size_t);
110 static void operator delete(void *); 111 static void operator delete(void *);
111 112
112 v8::Local<v8::Value> m_options; 113 v8::Local<v8::Value> m_options;
113 v8::Isolate* m_isolate; 114 v8::Isolate* m_isolate;
114 }; 115 };
115 116
116 } 117 }
117 118
118 #endif // Dictionary_h 119 #endif // Dictionary_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698