Source/bindings/v8/Dictionary.h - Issue 17063016: Remove leak of objects between isolated worlds on custom events.

Side by Side Diff: Source/bindings/v8/Dictionary.h

Issue 17063016: Remove leak of objects between isolated worlds on custom events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/security/isolatedWorld/custom-event.html ('K') | « LayoutTests/http/tests/security/isolatedWorld/custom-event-expected.txt ('k') | Source/bindings/v8/custom/V8CustomEventCustom.cpp » ('j') | Source/bindings/v8/custom/V8CustomEventCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 83 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
94 bool get(const String&, RefPtr<DOMError>&) const;	94 bool get(const String&, RefPtr<DOMError>&) const;

95 bool get(const String&, RefPtr<VoidCallback>&) const;	95 bool get(const String&, RefPtr<VoidCallback>&) const;

96	96

97 bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;	97 bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;

98 bool getOwnPropertyNames(Vector<String>&) const;	98 bool getOwnPropertyNames(Vector<String>&) const;

99	99

100 bool getWithUndefinedOrNullCheck(const String&, String&) const;	100 bool getWithUndefinedOrNullCheck(const String&, String&) const;

101	101

102 PassRefPtr<EventListener> getEventListener(const String&, Notification*) con st { return 0; }	102 PassRefPtr<EventListener> getEventListener(const String&, Notification*) con st { return 0; }

103	103

104 private:

105 bool getKey(const String& key, v8::Local<v8::Value>&) const;	104 bool getKey(const String& key, v8::Local<v8::Value>&) const;

106	105

	106 private:
	haraken 2013/06/22 13:16:46 Instead of making getKey() public, would you defin Instead of making getKey() public, would you define get(const String&, v8::Local<v8::Value>&) just like other get() methods? jww 2013/06/25 01:50:29 Done. Show quoted text On 2013/06/22 13:16:46, haraken wrote: > > Instead of making getKey() public, would you define get(const String&, > v8::Local<v8::Value>&) just like other get() methods? Done.
107 // This object can only be used safely when stack allocated because of v8::L ocal.	107 // This object can only be used safely when stack allocated because of v8::L ocal.

108 static void* operator new(size_t);	108 static void* operator new(size_t);

109 static void* operator new[](size_t);	109 static void* operator new[](size_t);

110 static void operator delete(void *);	110 static void operator delete(void *);

111	111

112 v8::Local<v8::Value> m_options;	112 v8::Local<v8::Value> m_options;

113 v8::Isolate* m_isolate;	113 v8::Isolate* m_isolate;

114 };	114 };

115	115

116 }	116 }

117	117

118 #endif // Dictionary_h	118 #endif // Dictionary_h

OLD	NEW