experimental/PdfViewer/generate_code.py - Issue 17063014: map podofo to SkPdfObject for SkPdfArray::operator[]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/generate_code.py

Issue 17063014: map podofo to SkPdfObject for SkPdfArray::operator[] (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: experimental/PdfViewer/generate_code.py

===================================================================

--- experimental/PdfViewer/generate_code.py (revision 9734)

+++ experimental/PdfViewer/generate_code.py (working copy)

@@ -526,7 +526,7 @@

manager.addClass('Array').check('podofoObj.GetDataType() == ePdfDataType_Array')\

.carbonCopyPublic('const int size() const {return fPodofoObj->GetArray().GetSize();}')\

- .carbonCopyPublic('SkPdfObject* operator[](int i) const {return new SkPdfObject(fPodofoDoc, &fPodofoObj->GetArray()[i]);}')\

+ .carbonCopyPublic('SkPdfObject* operator[](int i) const { SkPdfObject* ret = NULL; skpdfmap(*fPodofoDoc, fPodofoObj->GetArray()[i], &ret); return ret; }')\

manager.addClass('String').check('podofoObj.GetDataType() == ePdfDataType_String || podofoObj.GetDataType() == ePdfDataType_HexString')\

.carbonCopyPublic('const std::string& value() const {return fPodofoObj->GetString().GetStringUtf8();}')

« no previous file with comments | « experimental/PdfViewer/SkPdfFont.cpp ('k') | experimental/PdfViewer/pdf_viewer_main.cpp » ('j') | no next file with comments »