Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 17063007: Making all DOM types abstract and removing superfluous Dartium constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index b4bccf95575221b3f0cfc7f56a7bc7a926ca2a41..4222f0f4e33ef542472f80a9e20ea5922648923f 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -491,7 +491,14 @@ class HtmlDartGenerator(object):
ORIGINAL_FUNCTION = html_name)
def EmitHelpers(self, base_class):
- pass
+ if not self._members_emitter:
+ return
+
+ self._members_emitter.Emit(
+ ' // To suppress missing implicit constructor warnings.\n'
+ ' factory $CLASSNAME._() { '
+ 'throw new UnsupportedError("Not supported"); }\n',
+ CLASSNAME=self._interface_type_info.implementation_name())
def DeclareAttribute(self, attribute, type_name, attr_name, read_only):
""" Declares an attribute but does not include the code to invoke it.

Powered by Google App Engine
This is Rietveld 408576698