Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: sdk/lib/web_gl/dartium/web_gl_dartium.dart

Issue 17063007: Making all DOM types abstract and removing superfluous Dartium constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/web_gl/dartium/web_gl_dartium.dart
diff --git a/sdk/lib/web_gl/dartium/web_gl_dartium.dart b/sdk/lib/web_gl/dartium/web_gl_dartium.dart
index a1e5550c3a107f65173b888806f0484bb9550239..076acddb6523ea0550ba845360fb1c37c5fd7dd1 100644
--- a/sdk/lib/web_gl/dartium/web_gl_dartium.dart
+++ b/sdk/lib/web_gl/dartium/web_gl_dartium.dart
@@ -326,7 +326,8 @@ const int ZERO = RenderingContext.ZERO;
@DomName('WebGLActiveInfo')
@Unstable
class ActiveInfo extends NativeFieldWrapperClass1 {
- ActiveInfo.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ActiveInfo._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLActiveInfo.name')
@DocsEditable
@@ -352,7 +353,8 @@ class ActiveInfo extends NativeFieldWrapperClass1 {
@DomName('WebGLBuffer')
@Unstable
class Buffer extends NativeFieldWrapperClass1 {
- Buffer.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Buffer._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -367,7 +369,8 @@ class Buffer extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_atc/
@Experimental
class CompressedTextureAtc extends NativeFieldWrapperClass1 {
- CompressedTextureAtc.internal();
+ // To suppress missing implicit constructor warnings.
+ factory CompressedTextureAtc._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLCompressedTextureATC.COMPRESSED_RGBA_ATC_EXPLICIT_ALPHA_WEBGL')
@DocsEditable
@@ -394,7 +397,8 @@ class CompressedTextureAtc extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_pvrtc/
@Experimental // experimental
class CompressedTexturePvrtc extends NativeFieldWrapperClass1 {
- CompressedTexturePvrtc.internal();
+ // To suppress missing implicit constructor warnings.
+ factory CompressedTexturePvrtc._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLCompressedTexturePVRTC.COMPRESSED_RGBA_PVRTC_2BPPV1_IMG')
@DocsEditable
@@ -425,7 +429,8 @@ class CompressedTexturePvrtc extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/
@Experimental // experimental
class CompressedTextureS3TC extends NativeFieldWrapperClass1 {
- CompressedTextureS3TC.internal();
+ // To suppress missing implicit constructor warnings.
+ factory CompressedTextureS3TC._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLCompressedTextureS3TC.COMPRESSED_RGBA_S3TC_DXT1_EXT')
@DocsEditable
@@ -455,7 +460,8 @@ class CompressedTextureS3TC extends NativeFieldWrapperClass1 {
@DomName('WebGLContextAttributes')
@Unstable
class ContextAttributes extends NativeFieldWrapperClass1 {
- ContextAttributes.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ContextAttributes._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLContextAttributes.alpha')
@DocsEditable
@@ -517,7 +523,8 @@ class ContextAttributes extends NativeFieldWrapperClass1 {
@DomName('WebGLContextEvent')
@Unstable
class ContextEvent extends Event {
- ContextEvent.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ContextEvent._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLContextEvent.statusMessage')
@DocsEditable
@@ -536,7 +543,8 @@ class ContextEvent extends Event {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_debug_renderer_info/
@Experimental // experimental
class DebugRendererInfo extends NativeFieldWrapperClass1 {
- DebugRendererInfo.internal();
+ // To suppress missing implicit constructor warnings.
+ factory DebugRendererInfo._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLDebugRendererInfo.UNMASKED_RENDERER_WEBGL')
@DocsEditable
@@ -559,7 +567,8 @@ class DebugRendererInfo extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_debug_shaders/
@Experimental // experimental
class DebugShaders extends NativeFieldWrapperClass1 {
- DebugShaders.internal();
+ // To suppress missing implicit constructor warnings.
+ factory DebugShaders._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLDebugShaders.getTranslatedShaderSource')
@DocsEditable
@@ -578,7 +587,8 @@ class DebugShaders extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/
@Experimental // experimental
class DepthTexture extends NativeFieldWrapperClass1 {
- DepthTexture.internal();
+ // To suppress missing implicit constructor warnings.
+ factory DepthTexture._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLDepthTexture.UNSIGNED_INT_24_8_WEBGL')
@DocsEditable
@@ -597,7 +607,8 @@ class DepthTexture extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/specs/latest/
@Experimental // stable
class ExtDrawBuffers extends NativeFieldWrapperClass1 {
- ExtDrawBuffers.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ExtDrawBuffers._() { throw new UnsupportedError("Not supported"); }
@DomName('EXTDrawBuffers.COLOR_ATTACHMENT0_EXT')
@DocsEditable
@@ -748,7 +759,8 @@ class ExtDrawBuffers extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/EXT_frag_depth/
@Experimental
class ExtFragDepth extends NativeFieldWrapperClass1 {
- ExtFragDepth.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ExtFragDepth._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -763,7 +775,8 @@ class ExtFragDepth extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/EXT_texture_filter_anisotropic/
@Experimental
class ExtTextureFilterAnisotropic extends NativeFieldWrapperClass1 {
- ExtTextureFilterAnisotropic.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ExtTextureFilterAnisotropic._() { throw new UnsupportedError("Not supported"); }
@DomName('EXTTextureFilterAnisotropic.MAX_TEXTURE_MAX_ANISOTROPY_EXT')
@DocsEditable
@@ -785,7 +798,8 @@ class ExtTextureFilterAnisotropic extends NativeFieldWrapperClass1 {
@DomName('WebGLFramebuffer')
@Unstable
class Framebuffer extends NativeFieldWrapperClass1 {
- Framebuffer.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Framebuffer._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -800,7 +814,8 @@ class Framebuffer extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/
@Experimental
class LoseContext extends NativeFieldWrapperClass1 {
- LoseContext.internal();
+ // To suppress missing implicit constructor warnings.
+ factory LoseContext._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLLoseContext.loseContext')
@DocsEditable
@@ -823,7 +838,8 @@ class LoseContext extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_element_index_uint/
@Experimental // experimental
class OesElementIndexUint extends NativeFieldWrapperClass1 {
- OesElementIndexUint.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OesElementIndexUint._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -838,7 +854,8 @@ class OesElementIndexUint extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_standard_derivatives/
@Experimental // experimental
class OesStandardDerivatives extends NativeFieldWrapperClass1 {
- OesStandardDerivatives.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OesStandardDerivatives._() { throw new UnsupportedError("Not supported"); }
@DomName('OESStandardDerivatives.FRAGMENT_SHADER_DERIVATIVE_HINT_OES')
@DocsEditable
@@ -857,7 +874,8 @@ class OesStandardDerivatives extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_float/
@Experimental // experimental
class OesTextureFloat extends NativeFieldWrapperClass1 {
- OesTextureFloat.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OesTextureFloat._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -872,7 +890,8 @@ class OesTextureFloat extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_float_linear/
@Experimental
class OesTextureFloatLinear extends NativeFieldWrapperClass1 {
- OesTextureFloatLinear.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OesTextureFloatLinear._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -887,7 +906,8 @@ class OesTextureFloatLinear extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float/
@Experimental // experimental
class OesTextureHalfFloat extends NativeFieldWrapperClass1 {
- OesTextureHalfFloat.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OesTextureHalfFloat._() { throw new UnsupportedError("Not supported"); }
@DomName('OESTextureHalfFloat.HALF_FLOAT_OES')
@DocsEditable
@@ -906,7 +926,8 @@ class OesTextureHalfFloat extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float_linear/
@Experimental
class OesTextureHalfFloatLinear extends NativeFieldWrapperClass1 {
- OesTextureHalfFloatLinear.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OesTextureHalfFloatLinear._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -921,7 +942,8 @@ class OesTextureHalfFloatLinear extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/
@Experimental // experimental
class OesVertexArrayObject extends NativeFieldWrapperClass1 {
- OesVertexArrayObject.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OesVertexArrayObject._() { throw new UnsupportedError("Not supported"); }
@DomName('OESVertexArrayObject.VERTEX_ARRAY_BINDING_OES')
@DocsEditable
@@ -955,7 +977,8 @@ class OesVertexArrayObject extends NativeFieldWrapperClass1 {
@DomName('WebGLProgram')
@Unstable
class Program extends NativeFieldWrapperClass1 {
- Program.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Program._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -969,7 +992,8 @@ class Program extends NativeFieldWrapperClass1 {
@DomName('WebGLRenderbuffer')
@Unstable
class Renderbuffer extends NativeFieldWrapperClass1 {
- Renderbuffer.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Renderbuffer._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -986,7 +1010,8 @@ class Renderbuffer extends NativeFieldWrapperClass1 {
@Experimental
@Unstable
class RenderingContext extends CanvasRenderingContext {
- RenderingContext.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory RenderingContext._() { throw new UnsupportedError("Not supported"); }
/// Checks if this type is supported on the current platform.
static bool get supported => true;
@@ -2824,7 +2849,8 @@ class RenderingContext extends CanvasRenderingContext {
@DocsEditable
@DomName('WebGLShader')
class Shader extends NativeFieldWrapperClass1 {
- Shader.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Shader._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -2837,7 +2863,8 @@ class Shader extends NativeFieldWrapperClass1 {
@DocsEditable
@DomName('WebGLShaderPrecisionFormat')
class ShaderPrecisionFormat extends NativeFieldWrapperClass1 {
- ShaderPrecisionFormat.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ShaderPrecisionFormat._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLShaderPrecisionFormat.precision')
@DocsEditable
@@ -2862,7 +2889,8 @@ class ShaderPrecisionFormat extends NativeFieldWrapperClass1 {
@DocsEditable
@DomName('WebGLTexture')
class Texture extends NativeFieldWrapperClass1 {
- Texture.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Texture._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -2875,7 +2903,8 @@ class Texture extends NativeFieldWrapperClass1 {
@DocsEditable
@DomName('WebGLUniformLocation')
class UniformLocation extends NativeFieldWrapperClass1 {
- UniformLocation.internal();
+ // To suppress missing implicit constructor warnings.
+ factory UniformLocation._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -2890,6 +2919,7 @@ class UniformLocation extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/
@Experimental // experimental
class VertexArrayObject extends NativeFieldWrapperClass1 {
- VertexArrayObject.internal();
+ // To suppress missing implicit constructor warnings.
+ factory VertexArrayObject._() { throw new UnsupportedError("Not supported"); }
}

Powered by Google App Engine
This is Rietveld 408576698