Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: sdk/lib/indexed_db/dartium/indexed_db_dartium.dart

Issue 17063007: Making all DOM types abstract and removing superfluous Dartium constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
diff --git a/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart b/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
index d33a30ece459ecd7d6962f7f8e6b810e06804df0..62936f08b49d5e5f4225da1419587e52a03bdea1 100644
--- a/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
+++ b/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
@@ -59,7 +59,8 @@ class Cursor extends NativeFieldWrapperClass1 {
}
}
- Cursor.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Cursor._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBCursor.direction')
@DocsEditable
@@ -106,7 +107,8 @@ class Cursor extends NativeFieldWrapperClass1 {
@DomName('IDBCursorWithValue')
@Unstable
class CursorWithValue extends Cursor {
- CursorWithValue.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory CursorWithValue._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBCursorWithValue.value')
@DocsEditable
@@ -142,7 +144,8 @@ class Database extends EventTarget {
}
- Database.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Database._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBDatabase.abortEvent')
@DocsEditable
@@ -312,7 +315,8 @@ class IdbFactory extends NativeFieldWrapperClass1 {
return true;
}
- IdbFactory.internal();
+ // To suppress missing implicit constructor warnings.
+ factory IdbFactory._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBFactory.cmp')
@DocsEditable
@@ -458,7 +462,8 @@ class Index extends NativeFieldWrapperClass1 {
return ObjectStore._cursorStreamFromResult(request, autoAdvance);
}
- Index.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Index._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBIndex.keyPath')
@DocsEditable
@@ -577,7 +582,8 @@ class KeyRange extends NativeFieldWrapperClass1 {
_KeyRangeFactoryProvider.createKeyRange_bound(
lower, upper, lowerOpen, upperOpen);
- KeyRange.internal();
+ // To suppress missing implicit constructor warnings.
+ factory KeyRange._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBKeyRange.lower')
@DocsEditable
@@ -756,7 +762,8 @@ class ObjectStore extends NativeFieldWrapperClass1 {
return $dom_createIndex(name, keyPath, options);
}
- ObjectStore.internal();
+ // To suppress missing implicit constructor warnings.
+ factory ObjectStore._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBObjectStore.autoIncrement')
@DocsEditable
@@ -909,7 +916,8 @@ class ObjectStore extends NativeFieldWrapperClass1 {
@DomName('IDBOpenDBRequest')
@Unstable
class OpenDBRequest extends Request implements EventTarget {
- OpenDBRequest.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory OpenDBRequest._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBOpenDBRequest.blockedEvent')
@DocsEditable
@@ -939,7 +947,8 @@ class OpenDBRequest extends Request implements EventTarget {
@DomName('IDBRequest')
@Unstable
class Request extends EventTarget {
- Request.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Request._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBRequest.errorEvent')
@DocsEditable
@@ -1031,7 +1040,8 @@ class Transaction extends EventTarget {
return completer.future;
}
- Transaction.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory Transaction._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBTransaction.abortEvent')
@DocsEditable
@@ -1108,7 +1118,8 @@ class Transaction extends EventTarget {
@DomName('IDBVersionChangeEvent')
@Unstable
class VersionChangeEvent extends Event {
- VersionChangeEvent.internal() : super.internal();
+ // To suppress missing implicit constructor warnings.
+ factory VersionChangeEvent._() { throw new UnsupportedError("Not supported"); }
@DomName('IDBVersionChangeEvent.newVersion')
@DocsEditable
@@ -1130,6 +1141,7 @@ class VersionChangeEvent extends Event {
@DomName('IDBAny')
@deprecated // nonstandard
abstract class _IDBAny extends NativeFieldWrapperClass1 {
- _IDBAny.internal();
+ // To suppress missing implicit constructor warnings.
+ factory _IDBAny._() { throw new UnsupportedError("Not supported"); }
}

Powered by Google App Engine
This is Rietveld 408576698