sdk/lib/html/dartium/nativewrappers.dart - Issue 17063007: Making all DOM types abstract and removing superfluous Dartium constructors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/html/dartium/nativewrappers.dart

Issue 17063007: Making all DOM types abstract and removing superfluous Dartium constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library nativewrappers;	5 library nativewrappers;

6	6

7 class NativeFieldWrapperClass1 {	7 class NativeFieldWrapperClass1 {

	8 NativeFieldWrapperClass1() {
	blois 2013/06/19 23:16:19 Does this need to be a default generative construc Does this need to be a default generative constructor, or can it be a private factory constructor? vsm 2013/06/20 15:19:00 Either should work. We never should call the cons Show quoted text On 2013/06/19 23:16:19, blois wrote: > Does this need to be a default generative constructor, or can it be a private > factory constructor? Either should work. We never should call the constructor on this type or its subclasses.
	9 throw new UnsupportedError(

	10 "Generative constructors not supported on native types.");

	11 }

8 }	12 }

OLD	NEW

« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | no next file with comments »