chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java - Issue 1706293005: StaticTabSceneLayer owns ToolbarLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java

Issue 1706293005: StaticTabSceneLayer owns ToolbarLayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add toolbar layer when content tree set Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java

index 1cba75a1a3f7c657d518de31a1fc1c1934fcafbd..c6522ccd7f9bec304559b93ce3d775903601b5d7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java

@@ -72,7 +72,7 @@ public class StaticLayout extends ContextualSearchSupportedLayout {

mHandler = new Handler();

mUnstallRunnable = new UnstallRunnable();

mUnstalling = false;

- mSceneLayer = new StaticTabSceneLayer(R.id.control_container);

+ mSceneLayer = new StaticTabSceneLayer(context, R.id.control_container);

}

/**

@@ -236,6 +236,8 @@ public class StaticLayout extends ContextualSearchSupportedLayout {

mSceneLayer.update(dpToPx, contentViewport, layerTitleCache, tabContentManager,

fullscreenManager, layoutTab);

+ mSceneLayer.updateToolbarLayer(dpToPx, mRenderHost.getTopControlsBackgroundColor(),

+ mRenderHost.getTopControlsUrlBarAlpha(), fullscreenManager, resourceManager, this);

// TODO(pedrosimonetti): Coordinate w/ dtrainor@ to improve integration with TreeProvider.

SceneLayer overlayLayer = null;