chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java - Issue 1706293005: StaticTabSceneLayer owns ToolbarLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java

Issue 1706293005: StaticTabSceneLayer owns ToolbarLayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix findbugs issue Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java

index 7ac4f7e71aa06769884d7035eb10dfae88b0a0ca..842510bd3b99ecb1962b1b57e17894362e2986a8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java

@@ -11,7 +11,6 @@ import android.content.Intent;

import android.net.Uri;

import android.view.Menu;

import android.view.MenuItem;

-import android.view.View;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.firstrun.FirstRunStatus;

@@ -19,6 +18,7 @@ import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.document.TabDelegate;

import org.chromium.chrome.browser.webapps.FullScreenActivity;

+import org.chromium.chrome.browser.widget.ControlContainer;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.ui.base.PageTransition;

@@ -82,7 +82,8 @@ public class EmbedContentViewActivity extends FullScreenActivity {

}

@Override

- protected final ChromeFullscreenManager createFullscreenManager(View controlContainer) {

+ protected final ChromeFullscreenManager createFullscreenManager(

+ ControlContainer controlContainer) {

return null;

}