Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: fusl/src/regex/regcomp.c

Issue 1706293003: [fusl] Remove some more tabs (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fusl/src/network/lookup_name.c ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fusl/src/regex/regcomp.c
diff --git a/fusl/src/regex/regcomp.c b/fusl/src/regex/regcomp.c
index 0e1255f707f38704f3275f4aa28dd1fbad9ed8ef..45c0f349c327165fa18b9ce1df46f3ef9b07800d 100644
--- a/fusl/src/regex/regcomp.c
+++ b/fusl/src/regex/regcomp.c
@@ -2312,21 +2312,20 @@ static reg_errcode_t tre_make_trans(tre_pos_and_tags_t* p1,
trans = transitions + offs[p1->position];
while (trans->state != NULL) {
#if 0
- /* If we find a previous transition from `p1->position' to
- `p2->position', it is overwritten. This can happen only
- if there are nested loops in the regexp, like in "((a)*)*".
- In POSIX.2 repetition using the outer loop is always
- preferred over using the inner loop. Therefore the
- transition for the inner loop is useless and can be thrown
- away. */
- /* XXX - The same position is used for all nodes in a bracket
- expression, so this optimization cannot be used (it will
- break bracket expressions) unless I figure out a way to
- detect it here. */
- if (trans->state_id == p2->position)
- {
- break;
- }
+ /* If we find a previous transition from `p1->position' to
+ `p2->position', it is overwritten. This can happen only
+ if there are nested loops in the regexp, like in "((a)*)*".
+ In POSIX.2 repetition using the outer loop is always
+ preferred over using the inner loop. Therefore the
viettrungluu 2016/02/19 17:21:53 You still have a tab!
kulakowski 2016/02/19 18:03:22 Yeah. I said in the message that I didn't get ones
+ transition for the inner loop is useless and can be thrown
+ away. */
+ /* XXX - The same position is used for all nodes in a bracket
+ expression, so this optimization cannot be used (it will
+ break bracket expressions) unless I figure out a way to
+ detect it here. */
+ if (trans->state_id == p2->position) {
+ break;
+ }
#endif
trans++;
}
« no previous file with comments | « fusl/src/network/lookup_name.c ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698