Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1706293003: [fusl] Remove some more tabs (Closed)

Created:
4 years, 10 months ago by kulakowski
Modified:
4 years, 10 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[fusl] Remove some more tabs The remaining tabs occur only in assembly R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/29990a8142434d0ecda5cdd29beefbc592f3750d

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove #if 0 and tabs in comments #

Patch Set 3 : apptest rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -203 lines) Patch
M fusl/arch/i386/bits/syscall.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fusl/arch/mips/atomic_arch.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M fusl/src/crypt/crypt_blowfish.c View 1 3 chunks +2 lines, -21 lines 0 comments Download
M fusl/src/crypt/crypt_des.c View 1 3 chunks +6 lines, -6 lines 0 comments Download
M fusl/src/malloc/malloc.c View 1 1 chunk +0 lines, -21 lines 0 comments Download
M fusl/src/math/exp2l.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M fusl/src/math/tgamma.c View 1 1 chunk +0 lines, -51 lines 0 comments Download
M fusl/src/network/gethostbyname.c View 1 1 chunk +0 lines, -52 lines 0 comments Download
M fusl/src/network/lookup_name.c View 1 1 chunk +7 lines, -9 lines 0 comments Download
M fusl/src/regex/regcomp.c View 1 9 chunks +9 lines, -26 lines 0 comments Download
M fusl/src/regex/regexec.c View 1 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kulakowski
4 years, 10 months ago (2016-02-19 00:28:20 UTC) #1
viettrungluu
Actually, I think all these tabs are in #if 0 blocks. Is there a good ...
4 years, 10 months ago (2016-02-19 17:21:54 UTC) #2
kulakowski
PTAL. Nuked the #if 0s, and tabs in comments. I kept the ones in asm, ...
4 years, 10 months ago (2016-02-19 18:03:22 UTC) #4
viettrungluu
lgtm
4 years, 10 months ago (2016-02-19 22:16:55 UTC) #5
kulakowski
4 years, 10 months ago (2016-02-19 23:31:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
29990a8142434d0ecda5cdd29beefbc592f3750d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698