third_party/WebKit/LayoutTests/http/tests/svg/use-contenttype-blocked.html - Issue 1706243002: Don't use SVG resource documents with an unrecognized MIME-type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/svg/use-contenttype-blocked.html

Issue 1706243002: Don't use SVG resource documents with an unrecognized MIME-type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/svg/resources/echo-query.php ('k') | third_party/WebKit/LayoutTests/http/tests/svg/use-contenttype-blocked-expected.html » ('j') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.waitUntilDone();

	5 function finishTest() {

	6 if (window.testRunner)

	7 testRunner.notifyDone();

	8 }

	9 </script>

	10 <svg>

	11 <rect width="100" height="100" fill="green"/>

	12 <use

	13 onload="finishTest()" onerror="finishTest()"
	Mike West 2016/02/24 13:23:43 Does `onerror` fire? It seems like you could get Does `onerror` fire? It seems like you could get a more complete test that would also work in other browsers if you turned both of these into `testharness.js`-based things with expectations around the events that fire, and inspection of the expected DOM. fs 2016/02/24 17:04:59 Yes... Show quoted text On 2016/02/24 at 13:23:43, Mike West wrote: > Does `onerror` fire? Yes... Show quoted text > It seems like you could get a more complete test that would also work in other browsers if you turned both of these into `testharness.js`-based things with expectations around the events that fire, and inspection of the expected DOM. ...but only in Blink (and presumably WebKit) AFAIK. Converted to a testharness test though. Note though that there's no "browser portable" way to inspect the DOM (which is why I initially opted for a ref-test)
	14 xlink:href="resources/echo-query.php?type=application/json&payload=%3C%3Fxm l%20version%3D%271.0%27%3F%3E%3Csvg%20xmlns%3D%27http%3A//www.w3.org/2000/svg%27 %3E%3Crect%20id%3D%27rectangle%27%20width%3D%27100%27%20height%3D%27100%27%20fil l%3D%27red%27/%3E%3C/svg%3E#rectangle"/>

	15 </svg>

OLD	NEW