Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Side by Side Diff: src/a64/macro-assembler-a64-inl.h

Issue 170623002: A64: Tidy up Push and Pop TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/macro-assembler-a64.cc ('k') | src/a64/stub-cache-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1233 matching lines...) Expand 10 before | Expand all | Expand 10 after
1244 ASSERT(allow_macro_instructions_); 1244 ASSERT(allow_macro_instructions_);
1245 ASSERT(!rd.IsZero()); 1245 ASSERT(!rd.IsZero());
1246 uxtw(rd, rn); 1246 uxtw(rd, rn);
1247 } 1247 }
1248 1248
1249 1249
1250 void MacroAssembler::BumpSystemStackPointer(const Operand& space) { 1250 void MacroAssembler::BumpSystemStackPointer(const Operand& space) {
1251 ASSERT(!csp.Is(sp_)); 1251 ASSERT(!csp.Is(sp_));
1252 // TODO(jbramley): Several callers rely on this not using scratch registers, 1252 // TODO(jbramley): Several callers rely on this not using scratch registers,
1253 // so we use the assembler directly here. However, this means that large 1253 // so we use the assembler directly here. However, this means that large
1254 // immediate values of 'space' cannot be handled. Once we merge with V8, we 1254 // immediate values of 'space' cannot be handled cleanly. Once we implement
1255 // should try to use the new scope that controls scratch register usage. 1255 // our flexible scratch register idea, we could greatly simplify this
1256 // function.
1256 InstructionAccurateScope scope(this); 1257 InstructionAccurateScope scope(this);
1257 if ((space.IsImmediate()) && !is_uint12(space.immediate())) { 1258 if ((space.IsImmediate()) && !is_uint12(space.immediate())) {
1258 // The subtract instruction supports a 12-bit immediate, shifted left by 1259 // The subtract instruction supports a 12-bit immediate, shifted left by
1259 // zero or 12 bits. So, in two instructions, we can subtract any immediate 1260 // zero or 12 bits. So, in two instructions, we can subtract any immediate
1260 // between zero and (1 << 24) - 1. 1261 // between zero and (1 << 24) - 1.
1261 int64_t imm = space.immediate(); 1262 int64_t imm = space.immediate();
1262 ASSERT(is_uint24(imm)); 1263 ASSERT(is_uint24(imm));
1263 1264
1264 int64_t imm_top_12_bits = imm >> 12; 1265 int64_t imm_top_12_bits = imm >> 12;
1265 sub(csp, StackPointer(), imm_top_12_bits << 12); 1266 sub(csp, StackPointer(), imm_top_12_bits << 12);
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
1638 // characters are reserved for controlling features of the instrumentation. 1639 // characters are reserved for controlling features of the instrumentation.
1639 ASSERT(isprint(marker_name[0]) && isprint(marker_name[1])); 1640 ASSERT(isprint(marker_name[0]) && isprint(marker_name[1]));
1640 1641
1641 InstructionAccurateScope scope(this, 1); 1642 InstructionAccurateScope scope(this, 1);
1642 movn(xzr, (marker_name[1] << 8) | marker_name[0]); 1643 movn(xzr, (marker_name[1] << 8) | marker_name[0]);
1643 } 1644 }
1644 1645
1645 } } // namespace v8::internal 1646 } } // namespace v8::internal
1646 1647
1647 #endif // V8_A64_MACRO_ASSEMBLER_A64_INL_H_ 1648 #endif // V8_A64_MACRO_ASSEMBLER_A64_INL_H_
OLDNEW
« no previous file with comments | « src/a64/macro-assembler-a64.cc ('k') | src/a64/stub-cache-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698