Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/a64/code-stubs-a64.cc

Issue 170623002: A64: Tidy up Push and Pop TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/full-codegen-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 Isolate* isolate = masm->isolate(); 516 Isolate* isolate = masm->isolate();
517 isolate->counters()->code_stubs()->Increment(); 517 isolate->counters()->code_stubs()->Increment();
518 518
519 CodeStubInterfaceDescriptor* descriptor = GetInterfaceDescriptor(isolate); 519 CodeStubInterfaceDescriptor* descriptor = GetInterfaceDescriptor(isolate);
520 int param_count = descriptor->register_param_count_; 520 int param_count = descriptor->register_param_count_;
521 { 521 {
522 // Call the runtime system in a fresh internal frame. 522 // Call the runtime system in a fresh internal frame.
523 FrameScope scope(masm, StackFrame::INTERNAL); 523 FrameScope scope(masm, StackFrame::INTERNAL);
524 ASSERT((descriptor->register_param_count_ == 0) || 524 ASSERT((descriptor->register_param_count_ == 0) ||
525 x0.Is(descriptor->register_params_[param_count - 1])); 525 x0.Is(descriptor->register_params_[param_count - 1]));
526
526 // Push arguments 527 // Push arguments
527 // TODO(jbramley): Try to push these in blocks. 528 MacroAssembler::PushPopQueue queue(masm);
528 for (int i = 0; i < param_count; ++i) { 529 for (int i = 0; i < param_count; ++i) {
529 __ Push(descriptor->register_params_[i]); 530 queue.Queue(descriptor->register_params_[i]);
530 } 531 }
532 queue.PushQueued();
533
531 ExternalReference miss = descriptor->miss_handler(); 534 ExternalReference miss = descriptor->miss_handler();
532 __ CallExternalReference(miss, descriptor->register_param_count_); 535 __ CallExternalReference(miss, descriptor->register_param_count_);
533 } 536 }
534 537
535 __ Ret(); 538 __ Ret();
536 } 539 }
537 540
538 541
539 void DoubleToIStub::Generate(MacroAssembler* masm) { 542 void DoubleToIStub::Generate(MacroAssembler* masm) {
540 Label done; 543 Label done;
(...skipping 5255 matching lines...) Expand 10 before | Expand all | Expand 10 after
5796 MemOperand(fp, 6 * kPointerSize), 5799 MemOperand(fp, 6 * kPointerSize),
5797 NULL); 5800 NULL);
5798 } 5801 }
5799 5802
5800 5803
5801 #undef __ 5804 #undef __
5802 5805
5803 } } // namespace v8::internal 5806 } } // namespace v8::internal
5804 5807
5805 #endif // V8_TARGET_ARCH_A64 5808 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | src/a64/full-codegen-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698