Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1706223002: [Swarming] Isolate jsfunfuzz. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Isolate jsfunfuzz. This isolates all files necessary to run jsfunfuzz. The fuzz harness is copied into the jsfunfuzz directory and will be deleted in the old location after the migration to swarming. BUG=chromium:535160 LOG=n NOTRY=true Committed: https://crrev.com/2363a6a6d9144837224ebbc0b9c3873a806b2a36 Cr-Commit-Position: refs/heads/master@{#34122}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -33 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/jsfunfuzz/fuzz-harness.sh View 2 chunks +5 lines, -27 lines 1 comment Download
A + tools/jsfunfuzz/jsfunfuzz.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
A + tools/jsfunfuzz/jsfunfuzz.isolate View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL. Tested locally with "isolate.py remap" that all necessary files are included. https://codereview.chromium.org/1706223002/diff/1/tools/jsfunfuzz/fuzz-harness.sh File tools/jsfunfuzz/fuzz-harness.sh ...
4 years, 10 months ago (2016-02-18 15:01:42 UTC) #4
tandrii(chromium)
lgtm
4 years, 10 months ago (2016-02-18 15:22:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706223002/1
4 years, 10 months ago (2016-02-18 15:23:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 15:24:38 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 15:24:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2363a6a6d9144837224ebbc0b9c3873a806b2a36
Cr-Commit-Position: refs/heads/master@{#34122}

Powered by Google App Engine
This is Rietveld 408576698