Index: chrome/common/extensions/api/downloads.idl |
diff --git a/chrome/common/extensions/api/downloads.idl b/chrome/common/extensions/api/downloads.idl |
index 0381c887f0cdfc65ce7e821dcf600e25a71fdd8a..4cd1b627d6444c6cea94e352a1cb936cbdeba646 100644 |
--- a/chrome/common/extensions/api/downloads.idl |
+++ b/chrome/common/extensions/api/downloads.idl |
@@ -135,9 +135,14 @@ namespace downloads { |
long id; |
// Absolute URL. |
+ // URL that this download started from (before any redirects). |
asargent_no_longer_on_chrome
2016/06/16 22:11:41
nit: in the autogenerated documentation at https:/
mharanczyk
2016/06/23 10:33:21
Done.
|
DOMString url; |
// Absolute URL. |
+ // Actual download URL (final url in chain after all redirects). |
asargent_no_longer_on_chrome
2016/06/16 22:11:40
same nit here
mharanczyk
2016/06/23 10:33:21
Done.
|
+ DOMString finalUrl; |
+ |
+ // Absolute URL. |
DOMString referrer; |
// Absolute local path. |
@@ -263,6 +268,10 @@ namespace downloads { |
// <code>url</code> matches the given regular expression. |
DOMString? urlRegex; |
+ // Limits results to $(ref:DownloadItem) whose |
+ // <code>finalUrl</code> matches the given regular expression. |
+ DOMString? finalUrlRegex; |
+ |
// The maximum number of matching $(ref:DownloadItem) returned. Defaults to |
// 1000. Set to 0 in order to return all matching $(ref:DownloadItem). See |
// $(ref:search) for how to page through results. |
@@ -279,8 +288,13 @@ namespace downloads { |
long? id; |
// Absolute URL. |
+ // URL that this download started from (before any redirects). |
DOMString? url; |
+ // Absolute URL. |
+ // Actual download URL (final url in chain after all redirects). |
asargent_no_longer_on_chrome
2016/06/16 22:11:41
same nit here
mharanczyk
2016/06/23 10:33:21
Done.
|
+ DOMString? finalUrl; |
+ |
// Absolute local path. |
DOMString? filename; |
@@ -346,6 +360,9 @@ namespace downloads { |
// The change in <code>url</code>, if any. |
StringDelta? url; |
+ // The change in <code>finalUrl</code>, if any. |
asargent_no_longer_on_chrome
2016/06/16 22:11:41
It would be useful to mention here how finalUrl ca
asanka
2016/06/22 19:05:13
Neither url nor finalUrl can change for a download
mharanczyk
2016/06/23 10:33:21
So in what way should be this handled?
1. Just rem
asargent_no_longer_on_chrome
2016/06/23 16:35:52
I think it's fine to remove any optional elements
mharanczyk
2016/06/28 13:15:32
As it turn out those delta fields are actually set
asanka
2016/06/28 13:39:45
FTR, both of those behaviors are incorrect. Report
|
+ StringDelta? finalUrl; |
+ |
// The change in <code>filename</code>, if any. |
StringDelta? filename; |